GH-15857: AutoML pipeline support #16041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebhrusen
commented
Jan 29, 2024
Comment on lines
+416
to
+426
| //TODO: given that a transformer can reference a model (e.g. TE), | ||
| // and multiple transformers can refer | ||
| // to the same model, | ||
| // then we should be careful when deleting a transformer (resp. an entire pipeline) | ||
| // as we may delete sth that is still in use by another transformer (resp. pipeline). | ||
| // --> ref count? | ||
|
|
||
| //TODO: in AutoML, the same transformations are likely to occur on multiple (sometimes all) models, | ||
| // especially if the transformers parameters are not tuned. | ||
| // But it also depends if the transformers are context(CV)-sensitive (e.g. Target Encoding). | ||
| // See `CachingTransformer` for some thoughts about this. |
There was a problem hiding this comment.
these are just things to keep in mind, but not currently needed
sebhrusen
force-pushed
the
seb/gh-15856
branch
from
3c39c68 to
c0e024b
Compare
sebhrusen
force-pushed
the
seb/gh-15857
branch
from
5c4cac6 to
a13da23
Compare
sebhrusen
force-pushed
the
seb/gh-15856
branch
from
c0e024b to
d609ade
Compare
sebhrusen
force-pushed
the
seb/gh-15857
branch
from
a13da23 to
03cb8f4
Compare
sebhrusen
force-pushed
the
seb/gh-15856
branch
from
1d20956 to
3f0417e
Compare
sebhrusen
force-pushed
the
seb/gh-15857
branch
3 times, most recently
from
07d388d to
754a400
Compare
sebhrusen
force-pushed
the
seb/gh-15856
branch
from
5f12f8a to
487ca9e
Compare
sebhrusen
force-pushed
the
seb/gh-15857
branch
from
754a400 to
508269f
Compare
wendycwong
requested review from
tomasfryda,
maurever,
mn-mikke,
valenad1 and
syzonyuliia
sebhrusen
force-pushed
the
seb/gh-15856
branch
from
487ca9e to
4dd815e
Compare
sebhrusen
force-pushed
the
seb/gh-15857
branch
from
58ace4c to
cf8c097
Compare
sebhrusen
force-pushed
the
seb/gh-15856
branch
from
4dd815e to
5eab88a
Compare
sebhrusen
force-pushed
the
seb/gh-15857
branch
from
cf8c097 to
bb9047d
Compare
wendycwong
previously approved these changes
Feb 11, 2024
sebhrusen
force-pushed
the
seb/gh-15856
branch
from
5eab88a to
e4c0a1a
Compare
sebhrusen
force-pushed
the
seb/gh-15857
branch
from
bb9047d to
eaf4322
Compare
tomasfryda
previously approved these changes
Feb 12, 2024
h2o-automl/src/main/java/water/automl/api/schemas3/AutoMLBuildSpecV99.java
Show resolved
Hide resolved
sebhrusen
dismissed stale reviews from tomasfryda and wendycwong
The base branch was changed.
sebhrusen
force-pushed
the
seb/gh-15857
branch
from
eaf4322 to
cfbf707
Compare
|
@wendycwong, @tomasfryda this one is ready for merge. |
tomasfryda
approved these changes
Feb 15, 2024
mn-mikke
added a commit
that referenced
this pull request
Feb 27, 2024
valenad1
added a commit
that referenced
this pull request
Mar 8, 2024
valenad1
added a commit
that referenced
this pull request
Mar 11, 2024
* Revert "GH-15857: cleanup legacy TE integration in ModelBuilder and AutoML (#16061)" This reverts commit a8f309b. * Revert "GH-15857: AutoML pipeline support (#16041)" This reverts commit 17fa9ee. * Revert "GH-15856: Grid pipeline support (#16040)" This reverts commit b7ac670. * Revert "GH-15855: core pipeline API (#16039)" This reverts commit c15ea1e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrate TE in AutoML as a pipeline transformer: #15857